137 0 true 2008-10-28T12:32:08-10:00 26784 39 rails-22rc1-actionviewtemplatefinder 37190 10178 resolved 2.2rc1 actionview::templatefinder template view 2008-11-09T06:14:01-10:00 137 James Adam dstamat (at elctech) James Adam http://engines.lighthouseapp.com/projects/10178/tickets/39 TemplateFinder has been phased out in Rails, and some new conventions are in place. See similar issue here: http://groups.google.com/group/communityengine/browse_thread/thread/5e476a0c2ea44b45 Loading our application up dies in plugin.rb, on the reference to ActionView::TemplateFinder.process_view_paths(view_path), as ActionView::TemplateFinder no longer exists. TemplateFinder has been phased out in Rails, and some new conventions are in place. See similar issue here: http://groups.google.com/group/communityengine/browse_thread/thread/5e476a0c2ea44b45 Loading our application up dies in plugin.rb, on the reference to ActionView::TemplateFinder.process_view_paths(view_path), as ActionView::TemplateFinder no longer exists. <div><p>TemplateFinder has been phased out in Rails, and some new conventions are in place. See similar issue here: <a href="http://groups.google.com/group/communityengine/browse_thread/thread/5e476a0c2ea44b45"> http://groups.google.com/group/c...</a></p> <p>Loading our application up dies in plugin.rb, on the reference to ActionView::TemplateFinder.process_view_paths(view_path), as ActionView::TemplateFinder no longer exists.</p></div> 0 TemplateFinder has been phased out in Rails, and some new conventions are in place. See similar issue here: http://groups.google.com/group/communityengine/browse_thread/thread/5e476a0c2ea44b45 Loading our application up dies in plugin.rb, on the reference to ActionView::TemplateFinder.process_view_paths(view_path), as ActionView::TemplateFinder no longer exists. <div><p>TemplateFinder has been phased out in Rails, and some new conventions are in place. See similar issue here: <a href="http://groups.google.com/group/communityengine/browse_thread/thread/5e476a0c2ea44b45"> http://groups.google.com/group/c...</a></p> <p>Loading our application up dies in plugin.rb, on the reference to ActionView::TemplateFinder.process_view_paths(view_path), as ActionView::TemplateFinder no longer exists.</p></div> false 2008-10-28T12:32:09-10:00 26784 --- {} 39 rails-22rc1-actionviewtemplatefinder 0 10178 new 2.2rc1 actionview::templatefinder 2008-10-28T12:32:11-10:00 26784 dstamat (at elctech) dstamat (at elctech) http://engines.lighthouseapp.com/projects/10178/tickets/39 0 I also got the same issue, I digged a bit and found that: lib/engines/plugin.rb line 88 def add_plugin_view_paths view_path = File.join(directory, 'app', 'views') if File.exist?(view_path) ActionController::Base.view_paths.insert(1, view_path) # push it just underneath the app ActionView::TemplateFinder.process_view_paths(view_path) end end Perhaps we can use ActionController::Base.append_view_path(view_path) instead of ActionController::Base.view_paths.insert(1, view_path). Anyhow, I got /home/aa/apps/adva/vendor/rails/actionpack/lib/action_view/paths.rb:102:in `initialize': wrong number of arguments (2 for 3) (ArgumentError) when calling ActionController::Base.append_view_path(view_path) Any tips what method is use instead TemplateFinder.process_view_paths ? Cheers, Priit <div><p>I also got the same issue, I digged a bit and found that:</p> <p>lib/engines/plugin.rb line 88 def add_plugin_view_paths view_path = File.join(directory, 'app', 'views') if File.exist?(view_path)</p> <pre> <code>ActionController::Base.view_paths.insert(1, view_path) # push it just underneath the app ActionView::TemplateFinder.process_view_paths(view_path) </code> </pre> <p>end end</p> <p>Perhaps we can use ActionController::Base.append_view_path(view_path) instead of ActionController::Base.view_paths.insert(1, view_path).</p> <p>Anyhow, I got /home/aa/apps/adva/vendor/rails/actionpack/lib/action_view/paths.rb:102:in <code>initialize': wrong number of arguments (2 for 3) (ArgumentError)</code></p> <p>when calling ActionController::Base.append_view_path(view_path)</p> <p>Any tips what method is use instead TemplateFinder.process_view_paths ?</p> <p>Cheers, Priit</p></div> false 2008-10-29T12:08:54-10:00 26784 --- {} 39 rails-22rc1-actionviewtemplatefinder 0 10178 new 2.2rc1 actionview::templatefinder 2008-10-29T12:08:56-10:00 32675 Priit Tamboom dstamat (at elctech) http://engines.lighthouseapp.com/projects/10178/tickets/39 0 Sorry about messed up formating in the last post. In the morning I figured out, that my wrong number of arguments comes from safemode plugin what overides ActionView::Template initialization. Anyhow, ActionView::Base.append_view_path should be more clean way of adding new view paths. Cheers <div><p>Sorry about messed up formating in the last post.</p> <p>In the morning I figured out, that my wrong number of arguments comes from safemode plugin what overides ActionView::Template initialization.</p> <p>Anyhow, ActionView::Base.append_view_path should be more clean way of adding new view paths.</p> <p>Cheers</p></div> false 2008-10-29T23:50:29-10:00 26784 --- {} 39 rails-22rc1-actionviewtemplatefinder 0 10178 new 2.2rc1 actionview::templatefinder 2008-10-29T23:50:29-10:00 32675 Priit Tamboom dstamat (at elctech) http://engines.lighthouseapp.com/projects/10178/tickets/39 137 0 The issue with `append_view_paths` is that it adds the path to the env of the `VIEW_PATH`, whereas we actually want to push each plugin's view paths to the top of the stack, but just below the application views (so pushing them into position 1, rather than position 0). So, I'm not sure if it's possible to use `append_view_path` without radically changing either the precidence order of plugins, or the way that plugins are loaded. Does that make sense? Any ideas? <div><p>The issue with <code>append_view_paths</code> is that it adds the path to the env of the <code>VIEW_PATH</code>, whereas we actually want to push each plugin's view paths to the top of the stack, but just below the application views (so pushing them into position 1, rather than position 0).</p> <p>So, I'm not sure if it's possible to use <code>append_view_path</code> without radically changing either the precidence order of plugins, or the way that plugins are loaded.</p> <p>Does that make sense? Any ideas?</p></div> false 2008-10-30T04:23:34-10:00 26784 --- :tag: 2.2rc1 actionview::templatefinder :state: new :assigned_user: 39 rails-22rc1-actionviewtemplatefinder 0 10178 open 2.2rc1 actionview::templatefinder template view 2008-10-30T04:58:56-10:00 137 James Adam dstamat (at elctech) James Adam http://engines.lighthouseapp.com/projects/10178/tickets/39 137 0 Thanks for reply, now i got it. <div><p>Thanks for reply, now i got it.</p></div> false 2008-10-30T05:33:52-10:00 26784 --- {} 39 rails-22rc1-actionviewtemplatefinder 0 10178 open 2.2rc1 actionview::templatefinder template view 2008-10-30T05:33:57-10:00 32675 Priit Tamboom dstamat (at elctech) James Adam http://engines.lighthouseapp.com/projects/10178/tickets/39 137 0 Isn't this simply a case of changing: ActionView::TemplateFinder.process_view_paths(view_path) to: ActionView::Base.process_view_paths(view_path) I've got a coupe of apps running successfully on 2.2 with the above change. There's also another change required in action_mailer.rb: renderer.finder.view_paths.unshift(*ActionController::Base.view_paths.dup) becomes renderer.view_paths.unshift(*ActionController::Base.view_paths.dup) <div><p>Isn't this simply a case of changing:</p> <p>ActionView::TemplateFinder.process_view_paths(view_path)</p> <p>to:</p> <p>ActionView::Base.process_view_paths(view_path)</p> <p>I've got a coupe of apps running successfully on 2.2 with the above change.</p> <p>There's also another change required in action_mailer.rb:</p> <p> renderer.finder.view_paths.unshift(*ActionController::Base.view_paths.dup)</p> <p>becomes</p> <p> renderer.view_paths.unshift(*ActionController::Base.view_paths.dup)</p></div> false 2008-10-30T06:55:58-10:00 26784 --- {} 39 rails-22rc1-actionviewtemplatefinder 0 10178 open 2.2rc1 actionview::templatefinder template view 2008-10-30T06:56:00-10:00 1741 Tekin dstamat (at elctech) James Adam http://engines.lighthouseapp.com/projects/10178/tickets/39 137 0 This was fixed in the 'edge' branch a while back - apologies for not updating this ticket (http://github.com/lazyatom/engines/commit/499ce3b0480d8fa9375203f5efcadb8cf6ea9efe#comments) <div><p>This was fixed in the 'edge' branch a while back - apologies for not updating this ticket (<a href="http://github.com/lazyatom/engines/commit/499ce3b0480d8fa9375203f5efcadb8cf6ea9efe#comments">http://github.com/lazyatom/engin...</a>)</p></div> true 2008-11-09T06:14:00-10:00 26784 --- :state: open 39 rails-22rc1-actionviewtemplatefinder 0 10178 resolved 2.2rc1 actionview::templatefinder template view 2008-11-09T06:14:01-10:00 137 James Adam dstamat (at elctech) James Adam http://engines.lighthouseapp.com/projects/10178/tickets/39